Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update readme with additional info on test functions obfuscation #18

Closed
wants to merge 1 commit into from
Closed

docs: update readme with additional info on test functions obfuscation #18

wants to merge 1 commit into from

Conversation

vetalapo
Copy link

@vetalapo vetalapo commented Feb 1, 2024

Description

This pull request is a follow up on discussion on Discord -> Some students had concerns regarding lightly obfuscated functions in the Test Suite.

Type of change

Added a new section in README.md addressing possible concerns.
Described reasoning behind obfuscations.

P.S.: Couldn't find contribution guidelines. If this kind of update is needed, can do updates for the rest of the test tasks which contain obfuscation.

@MikAleinik
Copy link
Collaborator

Thanks for the proposed additions!
I believe that students should have no need to understand what exactly is hidden behind obfuscated code. And in a simple version its use is limited.
A student's use of a solution in obfuscated code from the assignment is equivalent to using any other ready-made solution.
@valerydluski please have your say on this issue

@valerydluski
Copy link
Contributor

I don't think we need it.

@vetalapo
Copy link
Author

vetalapo commented Feb 4, 2024

I made this PR because if this:
image

I had a feeling that it's going to fall through.

Well alright, you guys have to come up with an explainer somewhere then, why there's a need in obfuscated code for students' tasks and what exactly it does. Alternately remove portions of such code, or make tests part of https://app.rs.school/

See, it's pretty daunting to spin up a virtual machine / docker container every time I need to do a coding test. Because there is no way I trust that code or platform, especially after commentary I get here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants