Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): remove unsupported linux/arm64 #14

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

MSevey
Copy link
Contributor

@MSevey MSevey commented Jul 2, 2024

Overview

We don't support arm64 currently so removing it from the docker build

We will want to create a release after this.

Summary by CodeRabbit

  • Chores
    • Simplified the Docker workflow by focusing on building and pushing the amd64 Docker image under specific conditions.
    • Removed unnecessary logic for building and publishing images on certain branches.
    • Updated job naming and conditions for better clarity and efficiency.

Copy link

coderabbitai bot commented Jul 2, 2024

Walkthrough

The primary change in the .github/workflows/reusable_dockerfile_pipeline.yml file is the simplification of the workflow by focusing solely on building and pushing the amd64 Docker image under specific conditions. This involved removing logic for handling multiple branches and renaming the job for better clarity. The modifications streamline the process and target a specific architecture without the previous branching complexity.

Changes

File Change Summary
.github/workflows/reusable_dockerfile_pipeline.yml Removed logic for building and publishing images on main, master, and versioned branches. Updated the job name to "Build and Push amd64 Docker Image". Now builds and pushes the amd64 Docker image based on the output of steps.run_check.

Poem

In the code, the changes sing,
A simpler workflow, what joy it brings,
No more branches tangling tight,
Just amd64, pure and right,
Docker images, swift in flight,
Celebrate the code's new might! 🌟

Tip

AI model upgrade

gpt-4o model for reviews and chat is now live

OpenAI claims that this model is better at understanding and generating code than the previous models. Please join our Discord Community to provide any feedback or to report any issues.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 684d684 and f7b4c2f.

Files selected for processing (1)
  • .github/workflows/reusable_dockerfile_pipeline.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/reusable_dockerfile_pipeline.yml

@Manav-Aggarwal Manav-Aggarwal merged commit 03591d9 into main Jul 2, 2024
23 checks passed
@Manav-Aggarwal Manav-Aggarwal deleted the docker-clean-up branch July 2, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants