Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBP-1299] - add CBP platform connection #48

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Conversation

CristianCurteanu
Copy link
Contributor

No description provided.

@CristianCurteanu CristianCurteanu self-assigned this Jul 5, 2024
@CristianCurteanu CristianCurteanu marked this pull request as ready for review July 8, 2024 08:33
Copy link
Contributor

@AsafRollout AsafRollout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't see tests for state sender (in Rollout mode/ CBP mode)

src/Rox/Core/Consts/PropertyType.php Outdated Show resolved Hide resolved
src/Rox/Core/Consts/PropertyType.php Outdated Show resolved Hide resolved
src/Rox/Core/Core.php Outdated Show resolved Hide resolved
src/Rox/Core/Core.php Show resolved Hide resolved
src/Rox/Core/Roxx/Parser.php Outdated Show resolved Hide resolved
src/Rox/Core/XPack/Network/StateSender.php Outdated Show resolved Hide resolved
src/Rox/Core/XPack/Network/StateSender.php Outdated Show resolved Hide resolved
src/Rox/Server/Rox.php Outdated Show resolved Hide resolved
src/Rox/Server/Rox.php Outdated Show resolved Hide resolved
src/Rox/Server/Rox.php Outdated Show resolved Hide resolved
Copy link
Contributor

@AsafRollout AsafRollout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are 2 small comments for your consideration

src/Rox/Core/Core.php Outdated Show resolved Hide resolved
src/Rox/Core/Roxx/Parser.php Outdated Show resolved Hide resolved
@CristianCurteanu CristianCurteanu merged commit 63864c9 into master Jul 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants