fix(terser): always make at least 1 worker thread (#1594)

rollup · Oct 8, 2023 · bfacac4 · bfacac4
1 parent 841a039
commit bfacac4
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/packages/terser/src/worker-pool.ts b/packages/terser/src/worker-pool.ts
@@ -40,7 +40,8 @@ export class WorkerPool extends EventEmitter {
   constructor(options: WorkerPoolOptions) {
     super();
 
-    this.maxInstances = options.maxWorkers || cpus().length;
+    // cpus() can return [] on some platforms, and we always need at least 1 worker
+    this.maxInstances = options.maxWorkers || cpus().length || 1;
     this.filePath = options.filePath;
 
     this.on(freeWorker, () => {

diff --git a/packages/terser/test/test.js b/packages/terser/test/test.js
@@ -1,3 +1,5 @@
+const os = require('os');
+
 const test = require('ava');
 const { rollup } = require('rollup');
 
@@ -356,3 +358,21 @@ test.serial('terser preserve vars in nameCache when provided', async (t) => {
     }
   });
 });
+
+test.serial('minify when os.cpus().length === 0', async (t) => {
+  const original = os.cpus;
+  os.cpus = () => [];
+  try {
+    const bundle = await rollup({
+      input: 'test/fixtures/unminified.js',
+      plugins: [terser()]
+    });
+    const result = await bundle.generate({ format: 'cjs' });
+    t.is(result.output.length, 1);
+    const [output] = result.output;
+    t.is(output.code, '"use strict";window.a=5,window.a<3&&console.log(4);\n');
+    t.falsy(output.map);
+  } finally {
+    os.cpus = original;
+  }
+});