Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commonjs): make defaultIsModuleExports as funtion to config defaultIsModuleExports for each source #1052

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

morlay
Copy link
Contributor

@morlay morlay commented Nov 26, 2021

Rollup Plugin Name: commonjs

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

Fix #1046 with configration like

commonjs({
  defaultIsModuleExports: (id: string) => {
      if (/react-datetime/.exec(id)) {
        return false
      }
      return "auto"
  },
})

@morlay morlay changed the title feat(commonjs): make defaultIsModuleExports as funtion to config defa… feat(commonjs): make defaultIsModuleExports as funtion to config defaultIsModuleExports for each source Nov 26, 2021
@shellscape
Copy link
Collaborator

thanks!

@shellscape shellscape merged commit 3392e6e into rollup:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CommonJS plugin ignores __esModule field of minified webpack4 bundles
4 participants