fix(commonjs)!: check if defaultIsModuleExports is auto for getDefaultExportFromCjs #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion is auto, if defaultIsModuleExports option is auto, the export may should be wrapped with getDefaultExportFromCjs
|
Tests are required for fixes and features. |
flyingbirdhub
force-pushed
the
master
branch
from
33ad873
to
bf20931
Compare
i have fixed some test cases which fail to pass the tests, and add a test case for the problem solved by this mr |
shellscape
changed the title
shellscape
approved these changes
Dec 17, 2022
There was a problem hiding this comment.
@flyingbirdhub thanks for your patience on this. we're ready to merge this but there is a conflict that needs to be addressed first. please take a look
shellscape
changed the title
flyingbirdhub
force-pushed
the
master
branch
from
62801a8
to
eca3ed8
Compare
@shellscape i have solved this conflict, pls task a look, thanks |
|
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if defaultIsModuleExports option is auto, the export may should be wrapped with getDefaultExportFromCjs
Rollup Plugin Name:
@rollup/plugin-commonjsThis PR contains:
Are tests included?
Breaking Changes?
some break changes, when run test command, i do not know if it is right, but here need to be fixed in some way
List any relevant issue numbers:
#1209
Description