Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dsv): update type of processRow option #1493

Closed
wants to merge 1 commit into from

Conversation

jamesscottbrown
Copy link

Rollup Plugin Name: dsv

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers: #1492

Description

This updates the type definition for the processRow option to the DVS plugin, so that:

  • a function that doesn't return anything can be used
  • a function that returns a row object that includes non-string values (such as number or dates) can be used

@shellscape
Copy link
Collaborator

Thanks for the PR. https://github.com/rollup/plugins/blob/master/packages/dsv/test/types.ts will need to be updated to consider the changes you've made here.

@shellscape shellscape changed the title Update type of processRow option to DSV fix(dsv): update type of processRow option May 16, 2023
@shellscape
Copy link
Collaborator

@jamesscottbrown ping. if this reaches 60 days without a response, it'll be closed as abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants