-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wasm): include/exclude options #1558
Conversation
Thanks for the PR. CI is failing because while you added a new dependency, you hadn't run A test for |
b5a679c
to
b19cb14
Compare
Hi @shellscape , just updated lock file and README, welcome to review~ BTW: Taking a global perspective, maybe it's better to move these common options to the rollup plugin base other than implement it in every plugin itself. |
ee08274
to
d54c0a2
Compare
Hi @shellscape , no message for several days, is there still some problem? |
d54c0a2
to
46b3fde
Compare
Just updated the PR, take a look when you have time @shellscape |
@sky0014 looks good now, thanks. please update your branch from upstream so we can run the latest CI |
26f1901
to
91e0d95
Compare
Done. |
Rollup Plugin Name:
{@rollup/plugin-wasm}
This PR contains:
Are tests included?
The mainly include/exclude handle code is from
@rollup/pluginutils
like the other plugin does, It's already been tested yet.Breaking Changes?
Description
@rollup/plugin-wasm
missed the common include/exclude options, this PR added this part.