feat(alias): add warning to avoid unintended duplicate modules #1634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
alias
This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
resolves rollup/rollup#5250
Description
When the alias plugin is configured like this
and there a file like
https://stackblitz.com/edit/rollup-repro-s5tmli?file=src%2Fmain.js
then,
import './sub.js'
andimport '$/sub.js'
resolves to different module. (The same file is included in the bundle twice.)I believe this is not what people expect. Also IMO the fact that "
import 'src/sub.js'
doesn't work but$/sub.js
works" is difficult to understand.This PR adds a warning to catch these cases.
The warning will be shown for those that is using the alias plugin to duplicate the module, but I guess no one would do that. It'd be easier to create a different plugin in that case.