fix(commonjs): isRestorableCompiledEsm should also trigger code transform
#816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellscape
approved these changes
Feb 22, 2021
lukastaegert
approved these changes
Feb 22, 2021
|
We've got a codecov issue with CI. Since we aren't using coverage right now, I'll remove that on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
commonjsThis PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #762
Description
Currently if there are no inclusions of commonjs helpers, references to module/exports or dynamic requires - then the transform functions returns without modifying the code.
This PR changes that to consider
isRestorableCompiledEsm, as this basically means that an ES module was transformed into CJS, and we want to return an ES module.