Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bare imports #23

Closed
Rich-Harris opened this issue Dec 23, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@Rich-Harris
Copy link
Contributor

commented Dec 23, 2015

See rollup/rollup-plugin-node-resolve#1 (comment). Looks like maybe require('./side-effect') gets turned into import x from './side-effect' incorrectly – side-effect imports should remain bare.

@Rich-Harris Rich-Harris added the bug label Dec 23, 2015

@Rich-Harris

This comment has been minimized.

Copy link
Contributor Author

commented Dec 27, 2015

...though also need to consider cases like this:

require('console-group').install();
require('foo')(bar);

Rich-Harris added a commit that referenced this issue Dec 27, 2015

Rich-Harris added a commit that referenced this issue Dec 28, 2015

Rich-Harris added a commit that referenced this issue Dec 28, 2015

Merge pull request #25 from rollup/gh-23
handle bare imports (#23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.