Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Bare imports #23

Closed
Rich-Harris opened this issue Dec 23, 2015 · 1 comment · Fixed by #25
Closed

Bare imports #23

Rich-Harris opened this issue Dec 23, 2015 · 1 comment · Fixed by #25
Labels
bug

Comments

@Rich-Harris
Copy link
Contributor

See rollup/rollup-plugin-node-resolve#1 (comment). Looks like maybe require('./side-effect') gets turned into import x from './side-effect' incorrectly – side-effect imports should remain bare.
@Rich-Harris
Copy link
Contributor Author

...though also need to consider cases like this:

require('console-group').install();
require('foo')(bar);

Rich-Harris added a commit that referenced this issue Dec 27, 2015
@Rich-Harris
handle bare imports (#23)
1f06cba
@Rich-Harris Rich-Harris mentioned this issue Dec 27, 2015
Merged
Rich-Harris added a commit that referenced this issue Dec 28, 2015
@Rich-Harris
Merge branch 'master' into gh-23
bda3a51
Rich-Harris added a commit that referenced this issue Dec 28, 2015
@Rich-Harris
Merge pull request #25 from rollup/gh-23
ed57b87 
handle bare imports (#23)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

handle bare imports (#23) rollup/rollup-plugin-commonjs
1 participant
@Rich-Harris