Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

FIX: Stop mutating values option #22

Merged
merged 4 commits into from
Oct 6, 2018
Merged

FIX: Stop mutating values option #22

merged 4 commits into from
Oct 6, 2018

Conversation

caccialdo
Copy link
Contributor

This issue was identified after noticing that our build pipeline that relied on the values variable passed to rollup-plugin-replace after rollup finishes its work had been mutated by the lib.

lukastaegert
lukastaegert approved these changes Oct 5, 2018
View reviewed changes
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot and sorry for letting this wait so long. Will make sure this is released soon!

test/test.js Show resolved Hide resolved
@lukastaegert lukastaegert merged commit 0b62100 into rollup:master Oct 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caccialdo @lukastaegert