Add circularity prevention to value detection #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
approved these changes
May 16, 2018
| const testValue = this.hasUnknownTestValue ? UNKNOWN_VALUE : this.getTestValue(); | ||
| const testValue = this.hasUnknownTestValue | ||
| ? UNKNOWN_VALUE | ||
| : this.getTestValue(NEW_EXECUTION_PATH); |
There was a problem hiding this comment.
Is there definitely no risk that these NEW_EXECUTION_PATH constants will inadvertently get paths assigned or checked resulting in unwanted mutations for other paths using it?
There was a problem hiding this comment.
Not for now as everything is immutable i.e. when a value is added, everything is copied (this is what we have immutable.js for). It's probably NOT a very efficient solution. I hope to completely refactor it soon to make it more efficient and get rid of immutable.js.
|
Released as 0.59.1 |
calebeby
pushed a commit
to Pigmice2733/scouting-frontend
that referenced
this pull request
May 30, 2018
This Pull Request updates dependency [rollup](https://github.com/rollup/rollup) from `v0.59.0` to `v0.59.4` <details> <summary>Release Notes</summary> ### [`v0.59.4`](https://github.com/rollup/rollup/blob/master/CHANGELOG.md#​0594) [Compare Source](rollup/rollup@v0.59.3...v0.59.4) *2018-05-28* * Fix performance regression when many return statements are used ([#​2218](`rollup/rollup#2218)) --- ### [`v0.59.3`](https://github.com/rollup/rollup/blob/master/CHANGELOG.md#​0593) [Compare Source](rollup/rollup@v0.59.2...v0.59.3) *2018-05-24* * Fix reassignment tracking for constructor parameters ([#​2214](`rollup/rollup#2214)) --- ### [`v0.59.2`](https://github.com/rollup/rollup/blob/master/CHANGELOG.md#​0592) [Compare Source](rollup/rollup@v0.59.1...v0.59.2) *2018-05-21* * Fix reassignment tracking in for-in loops ([#​2205](`rollup/rollup#2205)) --- ### [`v0.59.1`](https://github.com/rollup/rollup/blob/master/CHANGELOG.md#​0591) [Compare Source](rollup/rollup@v0.59.0...v0.59.1) *2018-05-16* * Fix infinite recursion when determining literal values of circular structures ([#​2193](`rollup/rollup#2193)) * Fix invalid code when simplifying expressions without spaces ([#​2194](`rollup/rollup#2194)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds logic to handle circular structures when retrieving literal values similar to how this is done in other situations.
Resolves #2192 (hopefully).