Make initial ModuleInfo.meta mutable and maintain object identity #4328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
Technically it is a breaking change, but its effects are very subtle and will likely not be noticed considering how meta properties are merged at the moment, so I would consider it as non-breaking.
List any relevant issue numbers:
Description
This PR changes two things:
There is also now a test that ensures that the meta object (and moduleInfo) of a module is directly accessible after calling
this.load
even if the promise is not awaited. I actually need this for my current commonjs PR.@patak-dev, @antfu, @marvinhagemeister not sure if this is supported by Vite/WMR or if this would pose any problems for you?