lots of mostly permission-related fixes #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was never needed; just a remnant from the extension template.
@fregante made some improvements
Show them in the console of the background service worker.
Apparently wildcards are needed according to the manifest reference, even though I thought I previously saw that it wasn't. More importantly, webext-dynamic-content-scripts seems to filter out entries which don't contain '*' or '<all_urls>'. So add * back in.
Remove duplicates, and reorder a bit.
Turns out that putting only in content_scripts.matches was causing all kinds of grief.
This is from fregante/webext-permission-toggle#38 which is a better fix for fregante/webext-permission-toggle#29 than my own in fregante/webext-permission-toggle#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the injected HTML.
Fixes #110.