add logo and branding #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspiers
force-pushed
the
logo-theme
branch
2 times, most recently
from
d4ab56c
to
0465286
Compare
To support a light theme, we also add semantic colours for: - <code> - <code> border - background of the selected item in the settings drawer - settings <Toolbar> text and background
<Dialog> already uses <Paper> internally
Group first by component or use case, and secondly by individual property (text colour or background colour). Also tighten up type checking.
Separating CodeMirror theme definition from React rendering makes the code cleaner and prepares for adding a light theme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1 and #151.