New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle sequel qualified identifier join #405

Draft

alex-lairan wants to merge 1 commit into rom-rb:release-3.5 from Inthememory:handle_sequel_qualified_identifier_join

alex-lairan commented Jan 24, 2022

PostgreSQL has the possibility to handle multiple schemas.

Within ROM-SQL it is possible to query the table using Sequel::SQL::QualifiedIdentifier object instead of a symbol.

The join doesn't recognize Sequel::SQL::QualifiedIdentifier so this PR is just about fixing this to allow the join query to be made.

TODO :

Tests
Verify how SQL schema and other schema works together with a Sequel object instead of a symbol

Ideas of improvement :

Create an object that encapsulates the Sequel part so that it doesn't leak into the ROM Relation code. e.g : ROM::SQL::Postgres::SchemaScoppedTableName


          Handle Sequel::SQL::QualifiedIdentifier schema name for join

d842ff3

alex-lairan changed the base branch from master to release-3.5

January 24, 2022 13:07

alex-lairan mentioned this pull request

Support of PostgreSQL schemas #163

Open

MasanoriOnishi mentioned this pull request

Error when attempting to join relations across different databases #417

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet