Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax freezing policy for ROM::Configurable #616

Closed
v-kolesnikov opened this issue Dec 28, 2020 · 0 comments · Fixed by #617
Closed

Relax freezing policy for ROM::Configurable #616

v-kolesnikov opened this issue Dec 28, 2020 · 0 comments · Fixed by #617
Labels
core enhancement

Comments

@v-kolesnikov
Copy link
Collaborator

v-kolesnikov commented Dec 28, 2020 •
edited
Loading

Describe the bug

Freezing configuration settings in ROM::Support::Configurable is too aggressive

rom/core/lib/rom/support/configurable.rb

Line 39 in d34b479

settings.each_value(&:freeze)

To Reproduce

Configuration setting may be an object that has mutations on itself, so we shouldn't freeze that objects. For example: rom-rb/rom-elasticsearch#14

Expected behavior

Mutable objects could be able to set as configuration settings.
@v-kolesnikov v-kolesnikov changed the title Relax freezing policy for ROM::Configurable::Config Relax freezing policy for ROM::Configurable Dec 28, 2020
v-kolesnikov added a commit that referenced this issue Dec 28, 2020
@v-kolesnikov
#616 Relax freezing policy for ROM::Configurable
19611e7
@v-kolesnikov v-kolesnikov mentioned this issue Dec 28, 2020
Merged
v-kolesnikov added a commit that referenced this issue Dec 28, 2020
@v-kolesnikov
#616 Relax freezing policy for ROM::Configurable
bd5bdec
v-kolesnikov added a commit that referenced this issue Dec 29, 2020
@v-kolesnikov
#616 Relax freezing policy for ROM::Configurable
aa08e64
solnic added a commit that referenced this issue Dec 29, 2020
@solnic
Merge pull request #617 from rom-rb/616-dont-freeze
6355af0 
#616 Relax freezing policy for `ROM::Configurable`

[changelog]

changed: "Configuration values are no longer being frozen during setup process (issue #616 fixed via #617) (@v-kolesnikov)"
solnic pushed a commit that referenced this issue Dec 30, 2020
@v-kolesnikov @solnic
#616 Relax freezing policy for ROM::Configurable
495165d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#616 Relax freezing policy for ROM::Configurable rom-rb/rom
1 participant
@v-kolesnikov