Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goroutines return value in agent. #34

Open
flashvoid opened this issue Jan 28, 2016 · 1 comment
Open

Goroutines return value in agent. #34

flashvoid opened this issue Jan 28, 2016 · 1 comment

Comments

@flashvoid
Copy link
Contributor

So, our handlers (e.g. index) returns success asynchronously, after spawning processing thread. What happens if processing thread failed - well it returns an error but there is no one to act on it.

If processing thread will die in a middle of execution leaving half configured resource, i suggest we implement some slice of channels and will spin up goroutine that would poll these channels for return values from our worker.

There is probably not much we can really do once we discover an error but we should at least make some noise about it.

UPD: some new thoughts coming up, Pritesh mentioned nova notifier that can fail a VM but we'd have different backends and putting support for all the possible APIs out there smells bad. I suggest we implement something like hooks - arbitrary executables configured via commandline and called when needed (e.g. ./hooks/fail "token" "reason").

For different backend we can just swap hooks.

@jbrendel
Copy link
Contributor

I would like to understand under what circumstances our processing thread might fail.

pritesh pushed a commit that referenced this issue Sep 26, 2016
topology: add support for auto creating romana cidr, if one is not provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants