chore: allow injection of memory_resource into accept server #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes, it's a convention from boost.fibers library
…On Fri, Mar 8, 2024 at 11:29 AM Kostas Kyrimis ***@***.***> wrote:
***@***.**** commented on this pull request.
LGTM
------------------------------
In util/fibers/detail/fiber_interface.h
<#223 (comment)>:
> @@ -21,6 +22,33 @@ enum class Launch {
post // enqueue the fiber for activation but continue with the current fiber.
};
+// based on boost::context::fixedsize_stack but uses pmr::memory_resource for allocation.
+class FixedStackAllocator {
+ public:
+ using stack_context = boost::context::stack_context;
+
+ FixedStackAllocator(PMR_NS::memory_resource* mr, std::size_t size = 64 * 1024)
+ : mr_(mr), size_(size) {
+ }
+
+ stack_context allocate() {
+ void* vp = mr_->allocate(size_);
+ stack_context sctx;
+ sctx.size = size_;
+ sctx.sp = static_cast<char*>(vp) + sctx.size;
so the stack pointer points at the last address?
—
Reply to this email directly, view it on GitHub
<#223 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4BFCA5Z2GKEHJHHDIHR2TYXGAHXAVCNFSM6AAAAABEMPUV32VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRUGQ2TMNZUGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Best regards,
Roman
|
…ection fibers By default we preserve the current behavior and fallback with a memory resource that allocates using std::malloc/std::free. Also, provide an example of how to customize memory functions for OpenSSL. Finally, fix FiberTest.StackSize test that failed on alpine. Signed-off-by: Roman Gershman <roman@dragonflydb.io> Signed-off-by: Roman Gershman <romange@gmail.com>
dranikpg
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default we preserve the current behavior and fallback with a memory resource that allocates using std::malloc/std::free.
Also, provide an example of how to customize memory functions for OpenSSL.