chore: Build mimalloc as a C++ library #264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will have the benefit of throwing exceptions if allocations fail in the C++ APIs (like `new`)
chakaz
commented
May 9, 2024
cmake/third_party.cmake
Outdated
| CMAKE_PASS_FLAGS "-DCMAKE_BUILD_TYPE=Release -DMI_BUILD_SHARED=OFF -DMI_BUILD_TESTS=OFF \ | ||
| -DMI_INSTALL_TOPLEVEL=ON -DMI_OVERRIDE=OFF -DCMAKE_C_FLAGS=-g \ | ||
| ${HELIO_MIMALLOC_OPTS}" | ||
| CMAKE_PASS_FLAGS "-DCMAKE_BUILD_TYPE=Release -DMI_USE_CXX=ON -DMI_BUILD_SHARED=OFF \ |
There was a problem hiding this comment.
I only added -DMI_USE_CXX=ON, the rest is just bad diff display due to line breaks :|
|
@romange do you think we should merge this PR? |
|
… On Sun, Jun 23, 2024, 11:51 AM Shahar Mike ***@***.***> wrote:
@romange <https://github.com/romange> do you think we should merge this
PR?
I think that, given we know of scenarios in which mimalloc could return
nullptr (even if not in our production, although we also suspect other
cases in our production), it might be a good idea.
What are the downsides of doing so? It's the same code, if you compile it
with a C or C++ compiler, that shouldn't matter I think
—
Reply to this email directly, view it on GitHub
<#264 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4BFCG232KF4WXWZ6OVZ6LZI2ECTAVCNFSM6AAAAABHOK6PUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBUHEYDOMJSGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
romange
force-pushed
the
master
branch
3 times, most recently
from
45e35b1
to
2290be2
Compare
romange
force-pushed
the
master
branch
8 times, most recently
from
1402f6c
to
f102aa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will have the benefit of throwing exceptions if allocations fail in the C++ APIs (like
new)Related to #2914