Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary: Meets expectations #5

Open
zannain opened this issue Apr 27, 2018 · 0 comments
Open

Summary: Meets expectations #5

zannain opened this issue Apr 27, 2018 · 0 comments

Comments

@zannain
Copy link

zannain commented Apr 27, 2018

Awesome work on this mockups!! The HTML markup was very well organized, consistent with the indentation, and class and id attributes are well-named! You demonstrated proper use of media queries and flexbox. A few suggestions as a way to continue learning more and adding to your web development arsenal is to look into CSS Grids the which is a new player in the CSS3 specification and provides the developer more granular control when designing a responsive webpage. You may also want to consider implementing a CSS naming methodology to help avoid naming conflicts. I mentioned in a previous issue that as web pages become larger it can become harder to keep track of all the class and id attributes in a page and so in comes BEM to help you avoid naming conflicts!

A few more resources you might consider to deepen your understanding of Flexbox is this Flexbox Course. Codecademy also has a course on CSS Grids

Keep up the awesome work Roman!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant