Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeepKey device defined as a Trezor device #441

Open
doolio opened this issue Sep 11, 2023 · 2 comments
Open

KeepKey device defined as a Trezor device #441

doolio opened this issue Sep 11, 2023 · 2 comments

Comments

@doolio
Copy link
Contributor

doolio commented Sep 11, 2023

class KeepKey(trezor.Trezor):

Should this not be:

class KeepKey(interface.Device):
@romanz
Copy link
Owner

romanz commented Sep 17, 2023

I used inheritance to re-use TREZOR agent implementation with KeepKey class.

@doolio
Copy link
Contributor Author

doolio commented Sep 18, 2023

Right. I guess I was curious to why this was done for the KeepKey and not the other hardware devices. Feel free to close this if you don't wish to change how this is implemented. If you would like to align the KeepKey device with the others for consistency then I could submit a PR for consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants