Monitor queued jobs #131
Merged
Monitor queued jobs #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! Thanks! |
|
Yes, I can do that |
|
I was thinking about how this could impact existing implementations which are coupled to the Monitor model. Anyways we will have to publish this change in a new major version so I'd still prefer a config option but we can leave it enabled by default. |
AsemAlalami
commented
Jul 21, 2023
|
I added a config option, but please take a look to my comment |
|
Do you have anything to add or is this ready to merge? |
|
I think it's ready to merge |
|
Just a FYI, there are tests failing with the upcoming version. I'm looking into it but if you have an idea feel free to file a PR! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monitor queued jobs #62
also, I think it fixed the #76 issue
the PR adds "Initial Data" feature that initializes custom data to the monitor job