Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Add a "Rome: Restart LSP Server" command #3524

Closed
1 task done
MichaReiser opened this issue Oct 28, 2022 Discussed in #3202 · 0 comments · Fixed by #3533
Closed
1 task done

Add a "Rome: Restart LSP Server" command #3524

MichaReiser opened this issue Oct 28, 2022 Discussed in #3202 · 0 comments · Fixed by #3533
Labels
E-VScode Editors: VSCode enhancement New feature request or improvement to existing functionality good first issue Good for newcomers task A task, an action that needs to be performed

Comments

@MichaReiser
Copy link
Contributor

MichaReiser commented Oct 28, 2022

Discussed in #3202

Originally posted by lgarron September 10, 2022

Environment information

macOS 12.5.1
VSCode v1.71.0
Rome extension v0.14.1

What happened?

While adopting Rome for an existing codebase, I regularly need to edit rome.json and work with the revisited changes. There is currently no way to restart the LSP from the command palette other than the very heavy-handed "Reload Window" command. This has several undesirable side effects, such as losing recent file edit (undo) history.

Expected result

It would be nice to have a "Restart LSP Server" command, similar to other LSP extensions.

Automatically updating the LSP config when rome.json changes (#3195) would go a significant way towards many of the use cases for a "Restart LSP Server" command.

But there are some cases where it's useful to restart the LSP server even when rome.json hasn't changed, such as when you are re-compiling the LSP binary in-place (e.g. because you're recompiling it from scratch during developement/debugging of Rome itself).

Code of Conduct

  • I agree to follow Rome's Code of Conduct

Related Discussion: https://discord.com/channels/678763474494423051/940194723870683166/1035478240019615795

@MichaReiser MichaReiser added task A task, an action that needs to be performed E-VScode Editors: VSCode enhancement New feature request or improvement to existing functionality good first issue Good for newcomers labels Oct 28, 2022
@MichaReiser MichaReiser changed the title Add a "Rome: Restart LSP Server" command? Add a "Rome: Restart LSP Server" command Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E-VScode Editors: VSCode enhancement New feature request or improvement to existing functionality good first issue Good for newcomers task A task, an action that needs to be performed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant