Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

📎 Implement noStaticOnlyClass, @typescript-eslint/no-extraneous-class, unicorn/no-static-only-class #4482

Closed
Conaclos opened this issue May 15, 2023 · 6 comments · Fixed by #4514
Labels
A-Linter Area: linter good first issue Good for newcomers Help wanted Help would be really appreciated I-Easy Implementation: easy task, usually a good fit for new contributors task A task, an action that needs to be performed

Comments

@Conaclos
Copy link
Contributor

Description

Implement @typescript-eslint/no-extraneous-class, also supported by unicorn/no-static-only-class.

In contrast to @typescript-eslint/no-extraneous-class and similarly to unicorn/no-static-only-class, we should accept empty classes and classes that include only a constructor.

@Conaclos Conaclos added task A task, an action that needs to be performed good first issue Good for newcomers Help wanted Help would be really appreciated A-Linter Area: linter I-Easy Implementation: easy task, usually a good fit for new contributors labels May 15, 2023
@ematipico
Copy link
Contributor

ematipico commented May 15, 2023

@Conaclos
Copy link
Contributor Author

Static blocks are static, this should not change the behavior of the rule?

@ematipico
Copy link
Contributor

Should this rule be under the style group?

@Conaclos
Copy link
Contributor Author

Should this rule be under the style group?

Maybe suspicious?

@ematipico
Copy link
Contributor

This really seems a coding style rule. suspicious rules are

Rules that detect code that is likely to be incorrect or useless.

Which doesn't seem the case for this rule

@Conaclos
Copy link
Contributor Author

Ok style seems more adequate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Linter Area: linter good first issue Good for newcomers Help wanted Help would be really appreciated I-Easy Implementation: easy task, usually a good fit for new contributors task A task, an action that needs to be performed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants