Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Add noTemplateCurlyInString lint rule #112

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Add noTemplateCurlyInString lint rule #112

merged 1 commit into from
Mar 3, 2020

Conversation

eliassotodo
Copy link

@eliassotodo eliassotodo commented Mar 2, 2020 •
edited
Loading

Add no template curly in string for #94

@mattcompiles
Copy link
Contributor

mattcompiles commented Mar 2, 2020 •
edited
Loading

Thoughts on auto-fixing this to a template string?

@sebmck
Copy link
Contributor

sebmck commented Mar 3, 2020

Autofix for this would be difficult since you need to parse a substring. We would need to support offset positions in js-parser so that syntax errors would align, and figure out some UX if the interpolation is actually invalid.

@sebmck sebmck merged commit 3b53182 into rome:master Mar 3, 2020
@sebmck
Copy link
Contributor

sebmck commented Mar 3, 2020

Thank you!

@eliassotodo eliassotodo deleted the lint/no-template-curly-in-string branch March 3, 2020 21:21
@sebmck sebmck mentioned this pull request Mar 3, 2020
Closed
27 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sebmck sebmck sebmck left review comments

@ndresx ndresx ndresx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eliassotodo @mattcompiles @sebmck @ndresx @facebook-github-bot