This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
Add noImportAssign lint rule #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmck
reviewed
Mar 3, 2020
| ((node.type === 'AssignmentIdentifier' && isAssignment(path)) || | ||
| (node.type === 'ReferenceIdentifier' && | ||
| path.parentPath.node.type === 'UpdateExpression')) && | ||
| scope.getBindingAssert(node.name).kind === 'import' |
There was a problem hiding this comment.
getBindingAssert likely isn't the right call here. Setting a property on a known global shouldn't trigger this, which would be the case since getBinding doesn't return anything. Could you change this to getBinding and check the result for undefined? Other than that, looks good!
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've excluded something that the ESLint rule does which is handling cases like this:
because from #20 (comment) I got the impression that these linting rules are intended to be rules that can be reliably checked without a type system and cases similar to the above can't be. I'm happy to add the cases that ESLint supports if that's what people want.