Disallow unmatched opening square bracket in regular expressions #176
Conversation
|
Hi @baryla! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
baryla
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
As pointed out by @KevinKelbie in the discord channel, there's some more work that needs to be done. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
I think I missed that conversation. What's remaining? |
|
@sebmck here is a link to the discussion we had: https://discord.com/channels/678763474494423051/678763474930761739/688778390408527923 |
|
Closing this out due to inactivity. Feel free to open a new PR if you'd like to pick this up again! Thank you! |
The rule does pick out the opening square bracket but for some reason, the error underline is not right?
Btw. sorry about the long lint name 😂I'm open to better suggestions 😂