This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(parseOperator & parseQuantifier): '{' is parsed as Operator and … #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parseQuantifier correctly advances
This updates parseOperator and parseQuantifier to correctly handle {n} and {n,n} quantifiers.
parseQuantifier needs to advance to next token for the two edge cases where it finds its closing '}' token.
Otherwise, the parser will re-create a character token for that '}' that is really just a part of the quantifier.
ghost
mentioned this pull request
|
Thank you so much! Sorry for the delay in merging. If you run into any other problems feel free to join our Discord. |
|
No problem, hoping to pick up another item soon! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…parseQuantifier correctly advances
This updates parseOperator and parseQuantifier to correctly handle {n} and {n,n} quantifiers.
parseQuantifier needs to advance to next token for the two edge cases where it finds its closing '}' token.
Otherwise, the parser would've erroneously re-create a character token for that '}' that is really just a part of the quantifier.
For the case where a {n} or {n,n} quantifier is missing a target, diagnostics will read 'Nothing to repeat'.