This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feature(rome_js_parser): Extraction of variable declarations #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leops
reviewed
May 30, 2022
Deploying with
|
| Latest commit: |
59866a2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://04fcd59a.tools-8rn.pages.dev |
ematipico
reviewed
May 30, 2022
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
🔥 Regression (1409):🎉 Fixed (146):💥 Failed to Panic (1):ts/babel
ts/microsoft
|
MichaReiser
reviewed
May 31, 2022
leops
approved these changes
May 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the part that extracts variable declarations of the main PR (#2489).
For more details: #2488
This PR is the iterator that will extract as many events as possible with just one pass. At the moment I only extract "Declaration" from "JS_IDENTIFIER_BINDING". Will create other PRs until we reach the same 90% of the match of the original PR: #2489.
Future PRs will extract references, scopes, hoisting etc...
This PR also introduces the assertions to test the extraction. So we can write tests like
And we test if the token "a" was indeed extracted as a "Declaration".
Regression
Symbols regression is because I was signalling as
oktests where we could not find the original source code. Now I recover the source code from the .symbols file itself.