feature(rome_js_semantic): matching declarations and scopes

[xunilrj]

This PR is the part that matches declarations and scopes of the main PR (#2489).
For more details: #2488

This is just the first PR for this match, as we are solving only the most naive cases.

This also introduces a new assertion to test if the declaration is actually pointing to the correct scope. The important part here would be the @A, which means that the current declaration should be pointing to a scope named A.

if/*START A*/ (true) { let b/*#b @A*/ = 1; }

Better Diagnostics

Now the diagnostic specifies more clearly which test failed.

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	49c7664
Status:	✅  Deploy successful!
Preview URL:	https://e4c79ef2.tools-8rn.pages.dev
Branch Preview URL:	https://feature-semantic-declaration.tools-8rn.pages.dev

View logs

[github-actions]

Playground for commit b5d3fe2

[MichaReiser]

Have you checked the JS spec on what introduces a new scope? I believe this is (partially) the relevant section. https://tc39.es/ecma262/#sec-static-semantics-lexicallydeclarednames

Another alternative would be to look at rome classic's implementation. Maybe @ematipico has a pointer for you?

[ematipico]

Have you checked the JS spec on what introduces a new scope? I believe this is (partially) the relevant section. tc39.es/ecma262/#sec-static-semantics-lexicallydeclarednames

Another alternative would be to look at rome classic's implementation. Maybe @ematipico has a pointer for you?

Rome classic had a nice way to test things, although it was via snapshot tests: https://github.com/rome/tools/blob/archived-js/internal/compiler/scope/Scope.test.md

Maybe you can use it as inspiration.

This is where we stored all the globals: https://github.com/rome/tools/blob/archived-js/internal/compiler/scope/globals.ts, they were excluded from being tracked as bindings inside scopes.

This is where the bindings were created, and as you can see they have different kinds: https://github.com/rome/tools/blob/archived-js/internal/compiler/scope/bindings.ts

The creation of the scopes was done at node level by using the evaluators. I believe this is pretty nifty for various reasons:

• each evaluator that we create is bound to a specific node, which means that we know that specific evaluator will create bindings/scopes
• easy to debug

Here's the list of evaluators: https://github.com/rome/tools/tree/archived-js/internal/compiler/scope/evaluators
Here's the example for block statement: https://github.com/rome/tools/blob/archived-js/internal/compiler/scope/evaluators/JSBlockStatement.ts

We use the function .fork which creates a new scope but it keeps the same root scope.