This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 660
feature(rome_js_semantic): extraction of reference (read) events #2725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
🔥 Regression (28):
🎉 Fixed (78):
ts/babel
ts/microsoft
|
Also I noticed that we have 178 regression here? Is that accetable? |
No. Before the refactoring to please |
Deploying with Cloudflare Pages
|
xunilrj
force-pushed
the
feature/js-semantic-read-reference
branch
from
June 17, 2022 12:55
f289d99
to
a5465b2
Compare
leops
reviewed
Jun 17, 2022
ematipico
reviewed
Jun 17, 2022
ematipico
approved these changes
Jun 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the part that matches declarations and scopes of the main PR (#2489).
For more details: #2488
Now we are matching references and declarations on the naive case.
This is the first time we need to match the content of the code, so to avoid allocating strings and spreading a lifetime everywhere, I am storing only the hash of the
&str
.In theory, we could use interning, but I don´t need the values of string slices (yet), no this is actually faster.
var
and hoisting will be dealt in the next PR.