This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
Dockerised benchmark tool #4494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
connorjburton
commented
May 16, 2023
| @@ -228,7 +228,7 @@ function cloneProject(name, repository, dirs = []) { | |||
| console.log(`Updating git repository in directory ${projectDirectory}`); | |||
| inProjectDirectory.run("git reset --hard @{u}"); | |||
| inProjectDirectory.run("git clean -df"); | |||
| inProjectDirectory.run("git pull --depth=1"); | |||
| inProjectDirectory.run("git pull --depth=1 --ff-only"); | |||
There was a problem hiding this comment.
This was needed as the rust image used did not have any configuration set for how to merge when pulling, so it would fail.
|
Thank you @connorjburton for opening the PR! I am going to checkout your branch when I have time and test it! 🚀 |
ematipico
added
the
A-Tooling
unvalley
approved these changes
May 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding support for running the benchmark tool in Docker. The docker file has to be in the root, as it requires copying
cratesandxtaskto compilerome.This work greatly helps encouraging potential users of
rometo compare the performance against other popular tools on their machine, which gives a much better insight on the peformance improvement they will see. Given that the performance improvement can vary wildly between machines (from ~25-100x faster than prettier for formatting).It also has the additional benefit of a 1 line command and avoids installing dependencies to run the benchmark.
Test Plan
The documentation is updated with the command to be ran. This should be ran by someone else before merging this PR to ensure it works as expected.
Changelog
I don't believe this requires a changelog entry as it does not change the tooling itself.
Documentation
The documentation is updated.