Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "set_current_map" command to switch floor maps #54

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

kevinyc
Copy link
Contributor

@kevinyc kevinyc commented Mar 25, 2023

Added a set_current_map command for vacuum.send_command to change the vacuum floor map so that I no longer have to open up the Wyze app. Tested on firmware version 1.6.173.

@romedtino romedtino self-requested a review March 27, 2023 18:38
Copy link
Owner

@romedtino romedtino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just 2 changes that I think are pretty simple.

Maybe in the future I can have multiple camera entities to show each map.

Thanks for contributing!

custom_components/simple_wyze_vac/vacuum.py Outdated Show resolved Hide resolved
custom_components/simple_wyze_vac/vacuum.py Outdated Show resolved Hide resolved
Oh right, I can add my own suggestions lol
- Add check for params being valid
- Removed optional param for fn
@romedtino romedtino merged commit 77114be into romedtino:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants