Windows build #327

ten0s · 2022-06-09T13:38:24Z

This PR makes it possible to build and run on Windows using Node.js 12, see GitHub workflow for Windows.

At this point the next examples run successfully:

examples/hello-gtk.js
examples/drawing-area.js
examples/builder-auto-connect-signals.js
examples/builder.js
examples/entry.js

Closes #107

Fixes warning: SET_METHOD redefined

Fixes MSVC Error C2131

At some point something like https://stackoverflow.com/questions/4226308/msvc-equivalent-of-attribute-warn-unused-result/22759336#22759336 should be used

https://developer-old.gnome.org/gobject/stable/gobject-Closures.html#GClosureMarshal

Fixes gi.cc(373): error C3861: 'Export': identifier not found On Windows, for unclear reason the Nan namespace is lost for NAN_EXPORT(exports, RegisterClass)

Fixes segfault on Windows

ten0s · 2022-06-09T13:39:26Z

romgrk · 2022-06-14T21:12:30Z

Amazing work 😮 I have limited time these days but ping me when it's ready, I'll do a quick review and as long as the tests are passing for the existing OSes I'm ok with merging it.

Fixes some segfaults on Windows, like const val = new GObject.Value() val.init(GObject.TYPE_STRING) <- crash

Fixes some crases on Windows. Fixes 5 tests

Fixes 1 test on Windows

GType is gsize is 8 bytes gulong is 8 bytes on Linux and 4 bytes Windows Fixes some segfaults on Windows Fixes 3 tests on Windows

Number.MAX_SAFE_INTEGER is 8 bytes, but vInt is gulong 4 bytes on Windows and 8 bytes on Linux

Fixes 1 test on Windows

See comment in code

ten0s · 2022-07-08T16:20:43Z

@romgrk At this point all the tests pass on Linux and the majority of tests pass on Windows.

The two skipped tests callback.js and signal__non-introspected.js (both Gst) pass locally on my machine, but seems to crash in CI. Since Gst doesn't interest me I'm not going to look into them.

Also I disabled one test inside conversion__array.js introduced in #313, since it crashes somewhere inside node. See comment in code.

MacOS build still fails #326, so no idea if my changes somehow affected it.

romgrk · 2022-07-10T13:31:08Z

I've started the test suite, let's see what passes.

Overall LGTM, I'm ok merging as it is. Some windows support is better than no windows support.

One thing though, for the cairo.cc changes, those files are actually autogenerated, can you update the corresponding generator?

node-gtk/src/modules/cairo/generator.js

Lines 524 to 536 in ab813bb

    
               #define SET_METHOD(tpl, name) Nan::SetPrototypeMethod(tpl, #name, name) 
        
               static void AttachMethods(Local<FunctionTemplate> tpl) { 
        
                   ${functions.map(fn => 
        
                     (fn.attributes.version ? (() => { 
        
                       const [major, minor, micro] = fn.attributes.version.split('.') 
        
                       return '#if ' + [ 
        
                         (major ? 'CAIRO_VERSION_MAJOR >= ' + major : undefined), 
        
                         (minor ? 'CAIRO_VERSION_MINOR >= ' + minor : undefined), 
        
                         (micro ? 'CAIRO_VERSION_MICRO >= ' + micro : undefined), 
        
                       ].filter(Boolean).join(' && ') + '\n        ' 
        
                     })() : '') 
        
                     + `SET_METHOD(tpl, ${getJSName(fn.name)});`

ten0s · 2022-07-10T14:51:49Z

Will do.

Seems like I found the cause of
a1e0f72#diff-2ecb150c1fd88f2ab8aaf603ccee701e18d113bdb931ffc3aa4eb528243a3a38R1347-R1349

Will change, test and give you know.

On Windows g_free memory allocated with malloc/calloc crashes

ten0s · 2022-07-10T15:41:31Z

@romgrk Done

romgrk

A few comments, but LGTM. If you're not sure about the macos stuff try to leave it untouched.

README.md

binding.gyp

package.json

src/function.cc

romgrk · 2022-07-12T17:49:22Z

src/function.cc

@@ -448,16 +446,17 @@ Local<Value> FunctionCall (
     * Third, make the actual ffi_call
     */

-    void *ffi_args[func->n_total_args];
+    void **ffi_args = new void*[func->n_total_args]();


Same as above.

ten0s · 2022-07-12T18:44:59Z

@romgrk Done

romgrk · 2022-07-13T07:10:29Z

Good, nice work. Not sure I would have got around to doing the windows support by myself, so thanks a lot :)

ten0s · 2022-07-13T11:25:13Z

Great! Hopefully the project will start gaining more traction!

romgrk · 2022-07-13T11:53:32Z

Yeah, my dream as always been to have a clean & simple native alternative to electron. node-qt is probably better placed than this project, but the downside is they use Qt which is ugly by default.

ten0s added 14 commits June 6, 2022 16:09

Rename CALLBACK defined in Windows headers

2fdf7c8

Rename interface defined in Windows headers

846fede

Reuse SET_PROTOTYPE method from util.h

5ac5d29

Fixes warning: SET_METHOD redefined

Don't initialize array with a variable

53a35d4

Fixes MSVC Error C2131

Remove GCC attribute MSVC doesn't know

be1d425

At some point something like https://stackoverflow.com/questions/4226308/msvc-equivalent-of-attribute-warn-unused-result/22759336#22759336 should be used

Replace uint with guint

8dfeea3

https://developer-old.gnome.org/gobject/stable/gobject-Closures.html#GClosureMarshal

Move cflags & ldflags to Linux only

25c562b

Get rid of Darwin and force local node-pre-gyp

bb45385

Replace NAN_EXPORT with Nan:Export

8a880b9

Fixes gi.cc(373): error C3861: 'Export': identifier not found On Windows, for unclear reason the Nan namespace is lost for NAN_EXPORT(exports, RegisterClass)

Don't call g_source_add_unix_fd on Windows

be2aca7

Add Windows build config

c833cdd

Fix Windows include path

078d9a1

Use g_free where appropriate

0c20f46

Fixes segfault on Windows

Add GitHub workflow for Windows

c4c90fe

ten0s mentioned this pull request Jun 9, 2022

Npm or yarn installation error #324

Open

ten0s added 2 commits June 11, 2022 17:18

Add Node.js 16 Windows build

b5a8444

Use appropriate Node.js version

002f0d1

ten0s added 11 commits June 20, 2022 16:03

Ensure arg is zeroed

8bd78af

Fixes some segfaults on Windows, like const val = new GObject.Value() val.init(GObject.TYPE_STRING) <- crash

Improve tests skipping

858e1da

Skip tests knows to fail on Windows

0c4d415

Install gstreamer and libsoop to Windows

67d8e9b

Fix require test on Windows

bd8bf10

Don't free something that is not zero terminated

a1e0f72

Fixes some crases on Windows. Fixes 5 tests

Ensure allocated memory is zeroed

3ba64da

Fixes 1 test on Windows

GType is gsize, not gulong

93ce7e4

GType is gsize is 8 bytes gulong is 8 bytes on Linux and 4 bytes Windows Fixes some segfaults on Windows Fixes 3 tests on Windows

Get rid of platform specific uint and ulong

e00de69

Use specific types to mute warnings on Linux

08a0eef

Fix union__fields.js test on Windows

4d64179

Number.MAX_SAFE_INTEGER is 8 bytes, but vInt is gulong 4 bytes on Windows and 8 bytes on Linux

ten0s added 4 commits July 8, 2022 17:04

Cleanup

0f03417

Cleanup romgrk#2

b4f1d7b

Install gstreamer plugins

8e80dc9

Fixes 1 test on Windows

Partially enable conversion__array.js on Windows

0d45204

See comment in code

ten0s added 2 commits July 10, 2022 18:04

Fix generator

5835ddd

Replace malloc/calloc with g_malloc

56335f8

On Windows g_free memory allocated with malloc/calloc crashes

ten0s mentioned this pull request Jul 12, 2022

"$(uname)" was unexpected at this time. #107

Closed

romgrk reviewed Jul 12, 2022

View reviewed changes

ten0s added 2 commits July 12, 2022 21:16

Revert double-space

6f35acd

Heap allocation on non-Linux only

5363f27

romgrk merged commit 235b5e2 into romgrk:master Jul 13, 2022

ten0s deleted the windows-build branch December 23, 2022 16:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows build #327

Windows build #327

ten0s commented Jun 9, 2022 •

edited by romgrk

Loading

ten0s commented Jun 9, 2022

romgrk commented Jun 14, 2022

ten0s commented Jul 8, 2022

romgrk commented Jul 10, 2022

ten0s commented Jul 10, 2022

ten0s commented Jul 10, 2022

romgrk left a comment

romgrk Jul 12, 2022

ten0s Jul 12, 2022

ten0s commented Jul 12, 2022

romgrk commented Jul 13, 2022

ten0s commented Jul 13, 2022

romgrk commented Jul 13, 2022

Windows build #327

Windows build #327

Conversation

ten0s commented Jun 9, 2022 • edited by romgrk Loading

ten0s commented Jun 9, 2022

romgrk commented Jun 14, 2022

ten0s commented Jul 8, 2022

romgrk commented Jul 10, 2022

ten0s commented Jul 10, 2022

ten0s commented Jul 10, 2022

romgrk left a comment

Choose a reason for hiding this comment

romgrk Jul 12, 2022

Choose a reason for hiding this comment

ten0s Jul 12, 2022

Choose a reason for hiding this comment

ten0s commented Jul 12, 2022

romgrk commented Jul 13, 2022

ten0s commented Jul 13, 2022

romgrk commented Jul 13, 2022

ten0s commented Jun 9, 2022 •

edited by romgrk

Loading