Fixed date issue #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qcktap23 fix was not able to merge, I added some cases and different formats
While distutils package may be a great solution because setuptools is not built in, this setup method can't understand install_requires, extras_require and python_requires (and entry_points, etc... but it is not in the setup). Importing setuptools fixes these without having to use this module directly. It can be better to force the user to have setuptools but to keep the old method, I've added a try/except condition.
This was referenced Apr 27, 2020
|
Thanks @QuentiumYT! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qcktap23's fix was not able to merge, I added some cases and different formats.
I tested it and I have no more errors, even with french date formatting)