Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Network Error message when lauching a GBA game #1223

Open
update-freak opened this issue Oct 5, 2024 · 6 comments · Fixed by #1224
Open

[Bug] Network Error message when lauching a GBA game #1223

update-freak opened this issue Oct 5, 2024 · 6 comments · Fixed by #1224
Assignees
@adamantike
Labels
bug Something isn't working

Comments

@update-freak
Copy link

RomM version
3.5.1

Describe the bug
When I try to start a GBA game I got the message Network Error (see attached file)
2024-10-05 12_44_51-RomM

To Reproduce

  1. Start a GBA game

Expected behavior
Game will start

Desktop (please complete the following information):

  • OS: Windows11
  • Browser: Chrome 129
@update-freak update-freak added the bug Something isn't working label Oct 5, 2024
@gantoine
Copy link
Member

gantoine commented Oct 5, 2024

I need the browser console and container logs before we can look into this.

@sfaucheux
Copy link

I am experiencing the same issue, but it doesn't affect all roms.
I noticed that the ones whose filenames contain non-ASCII characters such as é in Pokémon Emerald Version.gba trigger the error. The same file with a e instead works as expected.
I hope this is useful.

@adamantike
Copy link
Collaborator

I was able to reproduce the issue when using filenames with non-ASCII characters. Will be working on a fix for that to have it patched ASAP. That was very useful, @sfaucheux, thank you!

@update-freak, is it also your case that failing roms have non-ASCII characters in their filenames? Or are you experiencing it with all roms?

@adamantike adamantike self-assigned this Oct 6, 2024
@update-freak
Copy link
Author

@sfaucheux Thank you very much for that info.
@adamantike For me it's the same problem with the é in Pokémon Smaragd-Edition

adamantike added a commit that referenced this issue Oct 6, 2024
@adamantike
fix: Escape URLs when files are served by nginx
60ff832 
When serving files using the `X-Accel-Redirect` header in nginx, the
header values must be URL-encoded. Otherwise, nginx will not be able
to serve the files if they contain special characters.

This commit adds a new `FileRedirectResponse` class to the `utils.nginx`
module, to simplify the creation of responses that serve files using the
`X-Accel-Redirect` header.

Fixes #1212, #1223.
@adamantike adamantike mentioned this issue Oct 6, 2024
Merged
@adamantike adamantike linked a pull request Oct 6, 2024 that will close this issue
fix: Escape URLs when files are served by nginx #1224
Merged
@adamantike
Copy link
Collaborator

A fix for this has been merged, and will be available in the next release!

@CarlesLlobet
Copy link

@adamantike When is the next release being launched?

It's been more than a month since fix was merged, and I still have the same issue.
Just wondering if its worth to manually rename all my library (or script it) to avoid unsuported chars, or I could wait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamantike adamantike

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Escape URLs when files are served by nginx rommapp/romm
5 participants
@gantoine @adamantike @CarlesLlobet @sfaucheux @update-freak