Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filename error #871

Closed
wants to merge 4 commits into from
Closed

Fix filename error #871

wants to merge 4 commits into from

Conversation

vincywindy
Copy link
Contributor

#865
Now not use django

zurdi15
zurdi15 previously approved these changes May 23, 2024
@zurdi15
Copy link
Member

zurdi15 commented May 23, 2024

Hi! Could you sign the commit and force push the branch? Commits must be signed in order to be merged

How to sign commits: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@zurdi15 zurdi15 self-requested a review May 23, 2024 08:44
@zurdi15 zurdi15 dismissed their stale review May 23, 2024 08:44

Not signed commit

@vincywindy
Copy link
Contributor Author

Hi! Could you sign the commit and force push the branch? Commits must be signed in order to be merged

How to sign commits: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Ok,I did it.This is the first time I create pr on github.

@zurdi15
Copy link
Member

zurdi15 commented May 23, 2024

Hi! Could you sign the commit and force push the branch? Commits must be signed in order to be merged
How to sign commits: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Ok,I did it.This is the first time I create pr on github.

That's ok :). Now seems pretty good, but you need to remove the first commit since that one is not signed. Maybe doing the job again in another branch/PR is easier and commiting directly the first commit, as you wish!

@vincywindy vincywindy closed this by deleting the head repository May 23, 2024
@vincywindy vincywindy mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants