misc: Migrate to SQLAlchemy declarative models #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gantoine
approved these changes
Jun 25, 2024
| from sqlalchemy import BigInteger, DateTime, ForeignKey, String, func | ||
| from sqlalchemy.orm import Mapped, mapped_column, relationship | ||
|
|
||
| if TYPE_CHECKING: |
There was a problem hiding this comment.
AAAAHHH I forgot you can do this 😫
|
|
||
|
|
||
| class Save(RomAsset): | ||
| __tablename__ = "saves" | ||
| __table_args__ = {"extend_existing": True} | ||
|
|
||
| emulator = Column(String(length=50), nullable=True) | ||
| emulator: Mapped[str | None] = mapped_column(String(length=50)) |
There was a problem hiding this comment.
don't we have to mark this nullable=True?
There was a problem hiding this comment.
We don't! The typehint takes care of that, as explained in step four, so Mapped[str] implicitly sets nullable=False, while Mapped[str | None] sets nullable=True.
This change applies the guided migration process recommended by SQLAlchemy [1], up to step 4, to have declarative ORM models that better support Python typing. The change was tested by running `alembic check`, which does not find any schema changes. Errors reported by `mypy` go down to 170, from the original 223 in the current `master` commit. [1] https://docs.sqlalchemy.org/en/20/changelog/whatsnew_20.html#migrating-an-existing-mapping
adamantike
force-pushed
the
misc/migrate-to-sqlalchemy-declarative-models
branch
from
66ccd38
to
b99eded
Compare
|
@adamantike If you happen to be in the discord, give me (arcaneasada) a ping in #open-development. And if not, feel free to join. We do all of our dev planning on there, and if you have more PRs in mind I'd love to hear what you have planned. https://discord.gg/ThzzNYq9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change applies the guided migration process recommended by SQLAlchemy [1], up to step 4, to have declarative ORM models that better support Python typing.
The change was tested by running
alembic check, which does not find any schema changes.Errors reported by
mypygo down to 170, from the original 223 in the currentmastercommit.[1] https://docs.sqlalchemy.org/en/20/changelog/whatsnew_20.html#migrating-an-existing-mapping