Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be smarter about integer deserialization #157

Merged
merged 2 commits into from Apr 14, 2019
Merged

Be smarter about integer deserialization #157

merged 2 commits into from Apr 14, 2019

Conversation

torkleyy
Copy link
Contributor

@torkleyy torkleyy commented Apr 5, 2019

Now, deserialize_any will try to find the best representation possible.

This is not a very pretty implementation, but it should work well.

Fixes #100
Fixes #155

Now, deserialize_any will try to find the best representation possible
Copy link

@azriel91 azriel91 left a comment

To semi-trained eyes, it looks good.

Just some small questions

src/de/tests.rs Show resolved Hide resolved
tests/large_number.rs Outdated Show resolved Hide resolved
@torkleyy
Copy link
Contributor Author

torkleyy commented Apr 12, 2019

Thanks for the review, addressed your comments.

@torkleyy
Copy link
Contributor Author

torkleyy commented Apr 14, 2019

bors r+

bors bot added a commit that referenced this issue Apr 14, 2019
157: Be smarter about integer deserialization r=torkleyy a=torkleyy

Now, `deserialize_any` will try to find the best representation possible.

This is not a very pretty implementation, but it should work well.

Fixes #100 
Fixes #155 

Co-authored-by: Thomas Schaller <torkleyy@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 14, 2019

Build succeeded

@bors bors bot merged commit 44fcaed into ron-rs:master Apr 14, 2019
2 checks passed
@torkleyy torkleyy deleted the nmb branch Apr 14, 2019
@CAD97 CAD97 mentioned this pull request May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants