-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#123: add tests for different enum representations #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you!
Congrats on your first PR ;)
Now we just need to make Travis happy, let me check why it failed.
Multiple tests seem to fail: |
(
type: "VariantA",
content: (),
) For such input serde tried to deserialize To fix it the following was done:
I am not sure, if this have broken something, but tests seem to pass. |
@torkleyy, is there anything that needs to be done? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
bors r+
166: #123: add tests for different enum representations r=torkleyy a=cpud36 This pull request is addressing issue #123. Currently it only adds tests mentioned in the issue. I'm not sure where to put the documentation, so would appreciate some guiding. If anything needs to be changed, please say it. This is my first PR. Co-authored-by: Katasonov Vladyslav <cpud47@gmail.com> Co-authored-by: cpud36 <vlad.1111@mail.ru>
Build succeeded |
This pull request is addressing issue #123.
Currently it only adds tests mentioned in the issue.
I'm not sure where to put the documentation, so would appreciate some guiding.
If anything needs to be changed, please say it. This is my first PR.