Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated uses of Error::description. #208

Merged
merged 1 commit into from Apr 8, 2020
Merged

Remove deprecated uses of Error::description. #208

merged 1 commit into from Apr 8, 2020

Conversation

iancormac84
Copy link
Contributor

@iancormac84 iancormac84 commented Apr 2, 2020

Ran tests and it seems to work.

kvark
kvark approved these changes Apr 2, 2020
Copy link
Collaborator

@kvark kvark left a comment

Looking good!
bors r+

bors bot added a commit that referenced this issue Apr 2, 2020
208: Remove deprecated uses of Error::description. r=kvark a=iancormac84

Ran tests and it seems to work.

Co-authored-by: iancormac84 <wilnathan@gmail.com>
@iancormac84
Copy link
Contributor Author

iancormac84 commented Apr 6, 2020

Says all checks have failed. Guidance?

@kvark
Copy link
Collaborator

kvark commented Apr 8, 2020

Travis has been pretty bad lately. I think it wants us to migrate to Travis.com.

@kvark kvark merged commit 1bb4cf6 into ron-rs:master Apr 8, 2020
1 check failed
@kvark
Copy link
Collaborator

kvark commented Apr 8, 2020

(Sorry about the delay! Currently swamped with work, barely keeping with notifications)

@iancormac84 iancormac84 deleted the undeprecate branch Apr 8, 2020
@CAD97 CAD97 mentioned this pull request May 1, 2020
@@ -62,7 +62,7 @@ impl fmt::Display for Error {
match *self {
Error::IoError(ref s) => write!(f, "{}", s),
Error::Message(ref s) => write!(f, "{}", s),
Error::Parser(_, pos) => write!(f, "{}: {}", pos, self.description()),
Error::Parser(_, pos) => write!(f, "{}: {}", pos, self),
Copy link
Contributor

@CAD97 CAD97 May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now infinitely recursive!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants