Handle escapes #23
Merged
Handle escapes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Serializer * Strings * Chars * Deserializer * Chars
torkleyy
commented
Jul 31, 2017
| @@ -228,9 +230,24 @@ impl<'de, 'a> de::Deserializer<'de> for &'a mut Deserializer<'de> { | |||
| fn deserialize_char<V>(self, visitor: V) -> Result<V::Value> | |||
| where V: Visitor<'de> | |||
| { | |||
| let parser = sym(b'\'') * take(1) - sym(b'\''); | |||
| let parser = sym(b'\'') * take(1); | |||
There was a problem hiding this comment.
There is most likely a better way to do this with POM, but it didn't work for me and this is somehow easier to read. I wonder if there is a parser library that is fast and nice to read.
kvark
approved these changes
Jul 31, 2017
|
Good stuff! |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, I thought it is wrong and it turns out it is. Seems there are really many things you can get wrong when writing a config format.