Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce explicit Some around raw values #494

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

juntyr
Copy link
Member

@juntyr juntyr commented Sep 1, 2023

Since a ron::value::RawValue can contain anything, implicit Some must be made explicit around it.

* [ ] I've included my change in CHANGELOG.md

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ba66c8e) 96.11% compared to head (bcdcfb9) 96.12%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #494   +/-   ##
=======================================
  Coverage   96.11%   96.12%           
=======================================
  Files          77       77           
  Lines        9867     9890   +23     
=======================================
+ Hits         9484     9507   +23     
  Misses        383      383           
Files Changed Coverage Δ
src/ser/mod.rs 96.77% <100.00%> (+0.03%) ⬆️
tests/407_raw_value.rs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juntyr juntyr merged commit f693d7e into ron-rs:master Sep 1, 2023
8 checks passed
@juntyr juntyr deleted the raw-value-implicit-some branch September 1, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants