Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for error messages and improve reader IO error position #497

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

juntyr
Copy link
Member

@juntyr juntyr commented Sep 3, 2023

* [ ] I've included my change in CHANGELOG.md

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.25% 🎉

Comparison is base (cc02072) 98.14% compared to head (bdcb99c) 99.40%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
+ Coverage   98.14%   99.40%   +1.25%     
==========================================
  Files          78       78              
  Lines       10308    10542     +234     
==========================================
+ Hits        10117    10479     +362     
+ Misses        191       63     -128     
Files Changed Coverage Δ
src/error.rs 100.00% <100.00%> (+46.37%) ⬆️
src/options.rs 100.00% <100.00%> (ø)
tests/options.rs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juntyr juntyr merged commit 10021d1 into ron-rs:master Sep 3, 2023
8 checks passed
@juntyr juntyr deleted the error-tests branch September 3, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants