Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #511: Allow deserialize_string for map fields originating from struct-formatted maps #512

Merged
merged 5 commits into from
Oct 7, 2023

Conversation

grindvoll
Copy link
Contributor

@grindvoll grindvoll commented Oct 2, 2023

This commit fixes an incoherence problem in the Deserializer implementation for fields in struct-encoded maps. deserialize_str was accepted, while deserialize_string was rejected. This behavior caused a problem when deserializing e.g. serde_json::Values from RON-files.

  • I've included my change in CHANGELOG.md

@grindvoll grindvoll marked this pull request as ready for review October 2, 2023 14:37
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1ff0efa) 100.00% compared to head (3dc831f) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #512   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           79        80    +1     
  Lines        11109     11178   +69     
=========================================
+ Hits         11109     11178   +69     
Files Coverage Δ
src/de/id.rs 100.00% <100.00%> (ø)
tests/511_deserialize_any_map_string_key.rs 100.00% <100.00%> (ø)
tests/non_identifier_identifier.rs 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juntyr
Copy link
Member

juntyr commented Oct 2, 2023

@grindvoll Thanks for the PR! It looks good to me once codecov is 100% and with the small CHANGELOG tweak.

Co-authored-by: Juniper Tyree <50025784+juntyr@users.noreply.github.com>
@juntyr

This comment was marked as resolved.

@juntyr juntyr mentioned this pull request Oct 6, 2023
49 tasks
@juntyr juntyr merged commit 2f3e5a8 into ron-rs:master Oct 7, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants