Limit the pretty depth #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkleyy
reviewed
Feb 6, 2018
Agreed. Thank you for coding this. |
Closed
|
Addressing 1/2 in a separate WIP PR #94 |
|
For the test I think asserting the above output would be enough. |
|
@torkleyy a test has been added. Notice that the hashmap only has one element (contrary to the |
torkleyy
approved these changes
Feb 9, 2018
| self.output += if self.separate_tuple_members() { | ||
| &config.new_line | ||
| } else { | ||
| " " |
There was a problem hiding this comment.
I assume this gets fixed in the follow-up? Otherwise we don't have whitespaces between tuple fields.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 9, 2018
93: Limit the pretty depth r=torkleyy a=kvark Fixes #92 cc @pyfisch Output of `cargo run --example encode`: ```yaml ( float: (2.18,-1.1,), tuple: ((),false,), map: {0:'1',8:'1',3:'5',1:'2',}, nested: (a:"Hello from \"RON\"",b:'b',), var: A(255,"",), array: [(),(),(),], ) ``` Unresolved questions: 1. should we omit the trailing comma for non-pretty output? Given that it's on the same line, it sort of makes sense. It would just affect more than just the `depth_limit` parameter. 2. do we still want to put spaces after commas for pretty output behind the depth limit?
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92
cc @pyfisch
Output of
cargo run --example encode:Unresolved questions:
depth_limitparameter.