Fixes deprecation warning regarding using includes over contains
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twokul
commented
Sep 22, 2016
•
twokul
commented
/Users/anavasar/Desktop/Screen Shot 2016-09-22 at 8.58.09 AM.png
twokul
commented
Sep 22, 2016
| @@ -2,12 +2,6 @@ | |||
| module.exports = { | |||
| scenarios: [ | |||
| { | |||
| name: 'default', | |||
There was a problem hiding this comment.
not sure what this was for since tests are running against release, beta and canary
There was a problem hiding this comment.
Good point, probably don't need that. Can you update .travis.yml to eliminate that test run as well?
/Users/anavasar/Desktop/Screen Shot 2016-09-22 at 8.58.09 AM.png
|
@ronco could you publish a new version? |
|
@twokul Published as 3.0.1 |
|
@ronco thanks! |
|
It should be noted that this breaks compatibility with all Ember versions below 2.8. A backward-compatible solution would be to use the ember-runtime-enumerable-includes-polyfill |
|
Thanks for pointing that out @simenheg . I definitely dropped the ball on the semver compliance there. I'll try to get a version with the polyfill out soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.