Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for Importer #19

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Add specs for Importer #19

merged 2 commits into from
Apr 29, 2024

Conversation

AI-Mozi
Copy link
Member

@AI-Mozi AI-Mozi commented Apr 29, 2024

#1

postmodern
postmodern requested changes Apr 29, 2024
View reviewed changes
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be basic checks for the Ronin::DB::IPAddress#address, Ronin::DB::HostName#name, Ronin::DB::Port#number, etc, to make sure the correct data is being imported.

@postmodern postmodern merged commit b79c5e0 into main Apr 29, 2024
14 checks passed
@postmodern postmodern added this to the 0.1.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postmodern postmodern postmodern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Phase 2
Status: Done
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AI-Mozi @postmodern